Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake fixes #673

Merged
merged 5 commits into from
Jun 24, 2019
Merged

cmake fixes #673

merged 5 commits into from
Jun 24, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Jun 17, 2019

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?

What this PR does / why we need it:

Fixes some cmake components in order to build Falco from source.

Which issue(s) this PR fixes:

Fixes #674

Special notes for your reviewer:

This PR depends on draios/sysdig#1441.
Since 1441 is based on the current sysdig dev branch this PR also changes the falco fields checksum because of the new liveness/readiness probe fields.

diff falcofieldsnew falcofieldsold                                                                  
86,87d85
< proc.is_container_liveness_probe
< proc.is_container_readiness_probe
170,171d167
< container.liveness_probe
< container.readiness_probe

Does this PR introduce a user-facing change?:

build(libcurl): without libidn2, libpsl and brotli
build(grpc): no implicit falltrough, no ignored qualifiers, no stringop truncation

@Kaizhe
Copy link
Contributor

Kaizhe commented Jun 17, 2019

/lgtm

@poiana
Copy link
Contributor

poiana commented Jun 17, 2019

LGTM label has been added.

Git tree hash: 35515de2bc3b27045d7c22cb23cc3fdfaa89809e

leodido and others added 4 commits June 21, 2019 09:19
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>

Co-Authored-By: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>

Co-Authored-By: Leonardo Di Donato <[email protected]>
fntlnz
fntlnz previously approved these changes Jun 21, 2019
@poiana
Copy link
Contributor

poiana commented Jun 21, 2019

LGTM label has been added.

Git tree hash: da0b8ade6969f80e592ef6641ae4fa07b3ada377

Signed-off-by: Lorenzo Fontana <[email protected]>

Co-Authored-By: Leonardo Di Donato <[email protected]>
@poiana poiana added the lgtm label Jun 21, 2019
@poiana
Copy link
Contributor

poiana commented Jun 21, 2019

LGTM label has been added.

Git tree hash: 8ea6be09f4d4489ee6c5533a63a332172320f344

@poiana
Copy link
Contributor

poiana commented Jun 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz changed the title wip: cmake fixes cmake fixes Jun 24, 2019
@fntlnz fntlnz merged commit 6834094 into dev Jun 24, 2019
@poiana poiana deleted the build/cmake branch June 24, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco fails to build from source because of issues with grpc cpp plugin and libcurl
4 participants